Skip to content

Conversation

albozek
Copy link
Contributor

@albozek albozek commented Aug 20, 2025

@albozek albozek requested review from a team and Copilot August 20, 2025 12:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates icon sizes across the admin UI by changing the CSS class from ibexa-icon--small to ibexa-icon--small-medium in various components and templates. The change affects icons throughout the application to implement a consistent base icon size.

  • Updated icon size classes across React components and Twig templates
  • Maintained consistent visual styling by replacing small icons with small-medium sized icons
  • Applied changes systematically across all UI modules including universal discovery, sub-items, multi-file upload, content tree, and admin templates

Reviewed Changes

Copilot reviewed 104 out of 104 changed files in this pull request and generated no comments.

File Description
JavaScript modules (various) Updated React components to use ibexa-icon--small-medium class for consistent icon sizing
Twig templates (various) Updated admin UI templates to use the new icon size class in buttons, forms, and navigation elements
Helper scripts Updated form validation helper to use new icon size for error messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@albozek albozek force-pushed the IBX-10440-base-size-icon branch from 45f3a46 to 560e079 Compare September 2, 2025 11:15
@albozek albozek force-pushed the IBX-10440-base-size-icon branch from b0d1527 to a1e0c80 Compare September 3, 2025 09:19
Copy link

sonarqubecloud bot commented Sep 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pawlakadrian pawlakadrian self-requested a review September 4, 2025 07:19
Copy link
Contributor

@pawlakadrian pawlakadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on DXP Commerce 5.0.x-dev

@dew326 dew326 merged commit 88b78db into main Sep 4, 2025
27 of 28 checks passed
@dew326 dew326 deleted the IBX-10440-base-size-icon branch September 4, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants